Standard js fixes #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr completes the nodejs integration as a Github workflow using the associated yml file (test.yml). I also have fixed the vast majority of the issues that nodejs brings up. You can see the folder added in this pr named standardjs-helpers which shows the python scripts that automates the resolving of these errors. For the errors that I receieved the go-ahead to nullify, I added those to the eslintrc.json file. The only kind of error that for whatever reason did not register in the eslintrc.json file is the missing comma error, as you can see is the only reason why the linter did not pass, with the standardjs check.